fix(electron-updater): relax multipart boundary regex to allow no space #9327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a4abb50 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mmaietta
reviewed
Nov 8, 2025
packages/electron-updater/src/differentialDownloader/multipleRangeDownloader.ts
Show resolved
Hide resolved
mmaietta
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Currently,
electron-updateruses a regex to detect multipart responses from the server when performing segmented downloads. The regex requires a space before theboundaryparameter:According to the HTTP standard, the space before boundary is optional. Servers that omit the space will fail detection, causing the updater to incorrectly treat the response as non-multipart, which can disable segmented downloads.
What this PR does
Updates the regex to allow the boundary parameter to appear immediately after the semicolon, removing the requirement for a space.